lkml.org 
[lkml]   [2009]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch] thinkpad_acpi: fix a build error
At Fri, 18 Dec 2009 12:28:15 -0200,
Henrique de Moraes Holschuh wrote:
>
> On Fri, 18 Dec 2009, Takashi Iwai wrote:
> > The patch isn't correct (I guess the upstream fix is same?).
> >
> > CONFIG_SOUND is a global config for sound subsystem. The relevant
> > functions are ALSA core part, which is CONFIG_SND.
> > So, the fix should be:
> >
> > depends on SND
> >
> > instead.
>
> Indeed. Ingo already fixed that too.
>
> Although I personally would prefer:
> select SOUND
> select SND

SND already depends on SOUND, so it's just superfluous.


Takashi


\
 
 \ /
  Last update: 2009-12-18 15:35    [W:0.084 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site