Messages in this thread | | | Date | Fri, 18 Dec 2009 15:31:34 +0100 | From | Takashi Iwai <> | Subject | Re: [Patch] thinkpad_acpi: fix a build error |
| |
At Fri, 18 Dec 2009 12:28:15 -0200, Henrique de Moraes Holschuh wrote: > > On Fri, 18 Dec 2009, Takashi Iwai wrote: > > The patch isn't correct (I guess the upstream fix is same?). > > > > CONFIG_SOUND is a global config for sound subsystem. The relevant > > functions are ALSA core part, which is CONFIG_SND. > > So, the fix should be: > > > > depends on SND > > > > instead. > > Indeed. Ingo already fixed that too. > > Although I personally would prefer: > select SOUND > select SND
SND already depends on SOUND, so it's just superfluous.
Takashi
| |