lkml.org 
[lkml]   [2009]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] scripts/checkpatch.pl: Change long line warning to 105 chars
    On Thu, Dec 17, 2009 at 09:12:24PM -0800, Joe Perches wrote:
    > On Thu, 2009-12-17 at 23:29 -0500, Valdis.Kletnieks@vt.edu wrote:
    > > Yeah, but I respectfully submit that if the regexp '^\t{6}' matches a non-
    > > continuation line, it's probably in its rights to whinge.
    > > grep -r -P '^\t{7:}(?!(.*,$|.*\);$))' . | more
    > > produces a whole lot of "this can't end well" output.
    >
    > I think this is a good test to add to checkpatch.
    >
    > Add 105 character long line WARN test
    > Add 80 character long line STRICT test
    > Add 6+ leading indent tabs test, consider restructuring
    >
    This looks like a reasonable compromise.


    \
     
     \ /
      Last update: 2009-12-18 06:59    [W:0.035 / U:119.976 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site