Messages in this thread | | | Subject | Re: [PATCH] Drop 80-character limit in checkpatch.pl | From | Valdis.Kletnieks@vt ... | Date | Thu, 17 Dec 2009 23:29:17 -0500 |
| |
On Thu, 17 Dec 2009 18:29:25 EST, Mikulas Patocka said:
> There is no need to make a script for it. The script isn't so smart to > tell what is understandable and what is nto.
Yeah, but I respectfully submit that if the regexp '^\t{6}' matches a non- continuation line, it's probably in its rights to whinge.
grep -r -P '^\t{7}(?!(.*,$|.*\);$))' . | more
produces a whole lot of "this can't end well" output. My favorite so far:
fs/reisersfs/do_balan.c, lines 460-477 (note: 3 leading tabs elided)
leaf_paste_entries(&bi, n + item_pos - ret_val, l_pos_in_item, 1, (struct reiserfs_de_head *) body, body + DEH_SIZE, tb-> insert_size [0] );
Yes, that used to be 24 more columns to the right. Gaak.
[unhandled content-type:application/pgp-signature] | |