Messages in this thread | | | Date | Thu, 17 Dec 2009 08:17:31 +0100 | From | Wolfgang Grandegger <> | Subject | Re: [PATCH 4/7] can/at91: don't check platform_get_irq's return value against zero |
| |
Alan Cox wrote: >> + if (!res || irq <= (int)NO_IRQ) { >> >> but this looks too ugly. (IMHO using NO_IRQ is already ugly.) > > No IRQ was a private variable for the drivers/ide stack internally and > only present in any form on a few odd platforms where it got "borrowed" > and hasn't yet been eliminated > > The absence of an IRQ is zero. A bus IRQ of zero is remapped by the OS.
OK, I was remembering some old issues with NO_IRQ. Next time I will read the commit message more carefully. Sorry for the noise.
Wolfgang.
| |