Messages in this thread | | | Date | Thu, 17 Dec 2009 19:39:44 +0300 | From | Anton Vorontsov <> | Subject | Re: [PATCH 6/7] spi/mpc8xxx: don't check platform_get_irq's return value against zero |
| |
On Wed, Dec 16, 2009 at 05:10:08PM +0100, Uwe Kleine-König wrote: > platform_get_irq returns -ENXIO on failure, so !irq was probably > always true. Better use (int)irq <= 0. Note that a return value of > zero is still handled as error even though this could mean irq0. > > This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that > changed the return value of platform_get_irq from 0 to -ENXIO on error. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Cc: David Vrabel <dvrabel@arcom.com> > Cc: Greg Kroah-Hartman <gregkh@suse.de> > Cc: David Brownell <dbrownell@users.sourceforge.net> > Cc: Grant Likely <grant.likely@secretlab.ca> > Cc: Kumar Gala <galak@kernel.crashing.org> > Cc: Anton Vorontsov <avorontsov@ru.mvista.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: spi-devel-general@lists.sourceforge.net > --- > drivers/spi/spi_mpc8xxx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c > index e9390d7..b13501a 100644 > --- a/drivers/spi/spi_mpc8xxx.c > +++ b/drivers/spi/spi_mpc8xxx.c > @@ -1339,7 +1339,7 @@ static int __devinit plat_mpc8xxx_spi_probe(struct platform_device *pdev) > return -EINVAL; > > irq = platform_get_irq(pdev, 0); > - if (!irq) > + if ((int)irq <= 0)
I tend to think that it's really hopeless to fix the platform_get_irq() in its current form, so can you get rid of this ugly cast and just make the irq signed?
And I'll be fine with it. :-(
-- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |