lkml.org 
[lkml]   [2009]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[49/90] b44: Fix wedge when using netconsole.
    2.6.31-stable review patch.  If anyone has any objections, please let us know.

    ------------------


    From: David S. Miller <davem@davemloft.net>

    [ Upstream commit 0cae200eec6330cd2c20b24279597be1da50dc93 ]

    Fixes kernel bugzilla #14691

    Due to the way netpoll works, it is perfectly legal to see
    NAPI already scheduled when new device events are pending
    in b44_interrupt().

    So logging a message about it is wrong and in fact harmful.

    Based upon a patch by Andreas Mohr.

    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/net/b44.c | 3 ---
    1 file changed, 3 deletions(-)

    --- a/drivers/net/b44.c
    +++ b/drivers/net/b44.c
    @@ -913,9 +913,6 @@ static irqreturn_t b44_interrupt(int irq
    bp->istat = istat;
    __b44_disable_ints(bp);
    __napi_schedule(&bp->napi);
    - } else {
    - printk(KERN_ERR PFX "%s: Error, poll already scheduled\n",
    - dev->name);
    }

    irq_ack:



    \
     
     \ /
      Last update: 2009-12-17 02:41    [W:0.029 / U:150.504 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site