lkml.org 
[lkml]   [2009]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[82/90] ipvs: zero usvc and udest
    2.6.31-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Simon Horman <horms@verge.net.au>

    commit 258c889362aa95d0ab534b38ce8c15d3009705b1 upstream.

    Make sure that any otherwise uninitialised fields of usvc are zero.

    This has been obvserved to cause a problem whereby the port of
    fwmark services may end up as a non-zero value which causes
    scheduling of a destination server to fail for persisitent services.

    As observed by Deon van der Merwe <dvdm@truteq.co.za>.
    This fix suggested by Julian Anastasov <ja@ssi.bg>.

    For good measure also zero udest.

    Cc: Deon van der Merwe <dvdm@truteq.co.za>
    Acked-by: Julian Anastasov <ja@ssi.bg>
    Signed-off-by: Simon Horman <horms@verge.net.au>
    Signed-off-by: Patrick McHardy <kaber@trash.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    net/netfilter/ipvs/ip_vs_ctl.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/net/netfilter/ipvs/ip_vs_ctl.c
    +++ b/net/netfilter/ipvs/ip_vs_ctl.c
    @@ -2713,6 +2713,8 @@ static int ip_vs_genl_parse_service(stru
    if (!(nla_af && (nla_fwmark || (nla_port && nla_protocol && nla_addr))))
    return -EINVAL;

    + memset(usvc, 0, sizeof(*usvc));
    +
    usvc->af = nla_get_u16(nla_af);
    #ifdef CONFIG_IP_VS_IPV6
    if (usvc->af != AF_INET && usvc->af != AF_INET6)
    @@ -2900,6 +2902,8 @@ static int ip_vs_genl_parse_dest(struct
    if (!(nla_addr && nla_port))
    return -EINVAL;

    + memset(udest, 0, sizeof(*udest));
    +
    nla_memcpy(&udest->addr, nla_addr, sizeof(udest->addr));
    udest->port = nla_get_u16(nla_port);




    \
     
     \ /
      Last update: 2009-12-17 02:29    [W:0.034 / U:0.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site