lkml.org 
[lkml]   [2009]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] cfq-iosced: Remove the check for same cfq group from allow_merge
    Date
    o allow_merge() already checks if submitting task is pointing to same cfqq
    as rq has been queued in. If everything is fine, we should not be having
    a task in one cgroup and having a pointer to cfqq in other cgroup.

    Well I guess in some situations it can happen and that is, when a random
    IO queue has been moved into root cgroup for group_isolation=0. In
    this case, tasks's cgroup/group is different from where actually cfqq is,
    but this is intentional and in this case merging should be allowed.

    The second situation is where due to close cooperator patches, multiple
    processes can be sharing a cfqq. If everything implemented right, we should
    not end up in a situation where tasks from different processes in different
    groups are sharing the same cfqq as we allow merging of cooperating queues
    only if they are in same group.

    Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
    ---
    block/cfq-iosched.c | 3 ---
    1 files changed, 0 insertions(+), 3 deletions(-)
    diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
    index e2f8046..a0e5347 100644
    --- a/block/cfq-iosched.c
    +++ b/block/cfq-iosched.c
    @@ -1513,9 +1513,6 @@ static int cfq_allow_merge(struct request_queue *q, struct request *rq,
    struct cfq_io_context *cic;
    struct cfq_queue *cfqq;

    - /* Deny merge if bio and rq don't belong to same cfq group */
    - if ((RQ_CFQQ(rq))->cfqg != cfq_get_cfqg(cfqd, 0))
    - return false;
    /*
    * Disallow merge of a sync bio into an async request.
    */
    --
    1.6.2.5


    \
     
     \ /
      Last update: 2009-12-16 23:57    [W:0.184 / U:0.036 seconds]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean