lkml.org 
[lkml]   [2009]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 6/7] spi/mpc8xxx: don't check platform_get_irq's return value against zero
    On Wed, Dec 16, 2009 at 05:10:08PM +0100, Uwe Kleine-König wrote:
    > platform_get_irq returns -ENXIO on failure, so !irq was probably
    > always true. Better use (int)irq <= 0. Note that a return value of
    > zero is still handled as error even though this could mean irq0.
    >
    > This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
    > changed the return value of platform_get_irq from 0 to -ENXIO on error.
    >
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    > ---

    Noooooo... :-(

    Please revert 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 instead,
    and fix platforms to remap HWIRQ0 to something that is not VIRQ0.

    IRQ0 is invalid for everything that is outside of arch/*.

    http://lkml.org/lkml/2005/11/22/159
    http://lkml.org/lkml/2005/11/22/213
    http://lkml.org/lkml/2005/11/22/227

    --
    Anton Vorontsov
    email: cbouatmailru@gmail.com
    irc://irc.freenode.net/bd2
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-12-16 17:41    [W:0.022 / U:77.552 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site