lkml.org 
[lkml]   [2009]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] OneNAND: Fix test of unsigned in onenand_otp_walk()
mtd->writesize and len are unsigned so the test does not work.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
you can test this with:

#include <stdio.h>

int main()
{
int c = 1, d = 1;
unsigned a = 30;
unsigned b = 10;

if ((b * c) - (d + a) < 0)
printf("good\n");
else
printf("bad\n");
return 0;
}


diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index ff66e43..cbe2711 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -2725,7 +2725,7 @@ static int onenand_otp_walk(struct mtd_info *mtd, loff_t from, size_t len,
}

/* Check User/Factory boundary */
- if (((mtd->writesize * otp_pages) - (from + len)) < 0)
+ if (mtd->writesize * otp_pages < from + len)
return 0;

onenand_get_device(mtd, FL_OTPING);

\
 
 \ /
  Last update: 2009-12-16 01:37    [W:0.031 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site