Messages in this thread | | | Date | Wed, 16 Dec 2009 01:09:03 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [RFC][Patch] IBM Real-Time "SMI Free" mode drive -v2 |
| |
On Tue, 15 Dec 2009, Jonathan Corbet wrote: > On Tue, 15 Dec 2009 12:09:48 -0800 > Keith Mannthey <kmannth@us.ibm.com> wrote: > > > +#include <linux/sysdev.h> > > +#include <asm/byteorder.h> > > +#include "rtl.h" > > + > > +static spinlock_t rtl_lock; > > You should probably include <linux/spinlock.h> for this.
And use:
DEFINE_SPINLOCK(rtl_lock);
because the lock is uninitialized otherwise. Running that code with lockdep would have warned about that.
Thanks,
tglx
| |