lkml.org 
[lkml]   [2009]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][Patch] IBM Real-Time "SMI Free" mode drive -v2
On Tue, 15 Dec 2009, Jonathan Corbet wrote:
> On Tue, 15 Dec 2009 12:09:48 -0800
> Keith Mannthey <kmannth@us.ibm.com> wrote:
>
> > +#include <linux/sysdev.h>
> > +#include <asm/byteorder.h>
> > +#include "rtl.h"
> > +
> > +static spinlock_t rtl_lock;
>
> You should probably include <linux/spinlock.h> for this.

And use:

DEFINE_SPINLOCK(rtl_lock);

because the lock is uninitialized otherwise. Running that code with
lockdep would have warned about that.

Thanks,

tglx


\
 
 \ /
  Last update: 2009-12-16 01:11    [W:1.210 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site