Messages in this thread | | | Date | Wed, 16 Dec 2009 08:25:29 +0900 | From | Minchan Kim <> | Subject | Re: [mmotm][PATCH 1/5] clean up mm_counter |
| |
On Tue, 15 Dec 2009 18:11:16 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > > Now, per-mm statistics counter is defined by macro in sched.h > > This patch modifies it to > - defined in mm.h as inlinf functions > - use array instead of macro's name creation. > > This patch is for reducing patch size in future patch to modify > implementation of per-mm counter. > > Changelog: 2009/12/14 > - added a struct rss_stat instead of bare counters. > - use memset instead of for() loop. > - rewrite macros into static inline functions. > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > --- > fs/proc/task_mmu.c | 4 - > include/linux/mm.h | 104 +++++++++++++++++++++++++++++++++++++++++++++++ > include/linux/mm_types.h | 33 +++++++++----- > include/linux/sched.h | 54 ------------------------ > kernel/fork.c | 3 - > kernel/tsacct.c | 1 > mm/filemap_xip.c | 2 > mm/fremap.c | 2 > mm/memory.c | 56 +++++++++++++++---------- > mm/oom_kill.c | 4 - > mm/rmap.c | 10 ++-- > mm/swapfile.c | 2 > 12 files changed, 174 insertions(+), 101 deletions(-) > > Index: mmotm-2.6.32-Dec8-pth/include/linux/mm.h > =================================================================== > --- mmotm-2.6.32-Dec8-pth.orig/include/linux/mm.h > +++ mmotm-2.6.32-Dec8-pth/include/linux/mm.h > @@ -868,6 +868,110 @@ extern int mprotect_fixup(struct vm_area > */ > int __get_user_pages_fast(unsigned long start, int nr_pages, int write, > struct page **pages); > +/* > + * per-process(per-mm_struct) statistics. > + */ > +#if USE_SPLIT_PTLOCKS > +/* > + * The mm counters are not protected by its page_table_lock, > + * so must be incremented atomically. > + */ > +static inline void set_mm_counter(struct mm_struct *mm, int member, long value) > +{ > + atomic_long_set(&mm->rss_stat.count[member], value); > +}
I can't find mm->rss_stat in this patch. Maybe it's part of next patch. It could break bisect.
Otherwise, Looks good to me.
Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
-- Kind regards, Minchan Kim
| |