lkml.org 
[lkml]   [2009]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] asiliantfb: Fix test of unsigned in asiliant_calc_dclk2()
    Ftarget, Fret, n and m are unsigned so the tests did not work.

    Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
    ---
    Found using coccinelle: http://coccinelle.lip6.fr/

    diff --git a/drivers/video/asiliantfb.c b/drivers/video/asiliantfb.c
    index 9fe90ce..e70bc22 100644
    --- a/drivers/video/asiliantfb.c
    +++ b/drivers/video/asiliantfb.c
    @@ -140,7 +140,7 @@ static void asiliant_calc_dclk2(u32 *ppixclock, u8 *dclk2_m, u8 *dclk2_n, u8 *dc

    /* 3 <= m <= 257 */
    if (m >= 3 && m <= 257) {
    - unsigned new_error = ((Ftarget * n) - (Fref * m)) >= 0 ?
    + unsigned new_error = Ftarget * n >= Fref * m ?
    ((Ftarget * n) - (Fref * m)) : ((Fref * m) - (Ftarget * n));
    if (new_error < best_error) {
    best_n = n;
    @@ -152,7 +152,7 @@ static void asiliant_calc_dclk2(u32 *ppixclock, u8 *dclk2_m, u8 *dclk2_n, u8 *dc
    else if (m <= 1028) {
    /* remember there are still only 8-bits of precision in m, so
    * avoid over-optimistic error calculations */
    - unsigned new_error = ((Ftarget * n) - (Fref * (m & ~3))) >= 0 ?
    + unsigned new_error = Ftarget * n >= Fref * (m & ~3) ?
    ((Ftarget * n) - (Fref * (m & ~3))) : ((Fref * (m & ~3)) - (Ftarget * n));
    if (new_error < best_error) {
    best_n = n;

    \
     
     \ /
      Last update: 2009-12-15 20:47    [W:0.030 / U:0.668 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site