lkml.org 
[lkml]   [2009]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] Input: Fix test of unsigned in altera_ps2_probe()
    ps2if->irq is unsigned so the test does not work.

    Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
    ---
    Found using coccinelle: http://coccinelle.lip6.fr/

    diff --git a/drivers/input/serio/altera_ps2.c b/drivers/input/serio/altera_ps2.c
    index f479ea5..3aa8f2e 100644
    --- a/drivers/input/serio/altera_ps2.c
    +++ b/drivers/input/serio/altera_ps2.c
    @@ -83,7 +83,7 @@ static int altera_ps2_probe(struct platform_device *pdev)
    {
    struct ps2if *ps2if;
    struct serio *serio;
    - int error;
    + int error, irq;

    ps2if = kzalloc(sizeof(struct ps2if), GFP_KERNEL);
    serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
    @@ -108,11 +108,13 @@ static int altera_ps2_probe(struct platform_device *pdev)
    goto err_free_mem;
    }

    - ps2if->irq = platform_get_irq(pdev, 0);
    - if (ps2if->irq < 0) {
    +
    + irq = platform_get_irq(pdev, 0);
    + if (irq < 0) {
    error = -ENXIO;
    goto err_free_mem;
    }
    + ps2if->irq = irq;

    if (!request_mem_region(ps2if->iomem_res->start,
    resource_size(ps2if->iomem_res), pdev->name)) {

    \
     
     \ /
      Last update: 2009-12-15 18:03    [W:0.022 / U:1.632 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site