lkml.org 
[lkml]   [2009]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFC/PATCH 2/4] input: misc: twl4030: move to request_threaded_irq
    Date
    move to request_threaded_irq() on twl4030 children.

    Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
    ---
    drivers/input/misc/twl4030-pwrbutton.c | 12 +-----------
    1 files changed, 1 insertions(+), 11 deletions(-)

    diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
    index f5fc997..cd47d9e 100644
    --- a/drivers/input/misc/twl4030-pwrbutton.c
    +++ b/drivers/input/misc/twl4030-pwrbutton.c
    @@ -39,16 +39,6 @@ static irqreturn_t powerbutton_irq(int irq, void *_pwr)
    int err;
    u8 value;

    -#ifdef CONFIG_LOCKDEP
    - /* WORKAROUND for lockdep forcing IRQF_DISABLED on us, which
    - * we don't want and can't tolerate since this is a threaded
    - * IRQ and can sleep due to the i2c reads it has to issue.
    - * Although it might be friendlier not to borrow this thread
    - * context...
    - */
    - local_irq_enable();
    -#endif
    -
    err = twl4030_i2c_read_u8(TWL4030_MODULE_PM_MASTER, &value,
    STS_HW_CONDITIONS);
    if (!err) {
    @@ -80,7 +70,7 @@ static int __devinit twl4030_pwrbutton_probe(struct platform_device *pdev)
    pwr->phys = "twl4030_pwrbutton/input0";
    pwr->dev.parent = &pdev->dev;

    - err = request_irq(irq, powerbutton_irq,
    + err = request_threaded_irq(irq, NULL, powerbutton_irq,
    IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
    "twl4030_pwrbutton", pwr);
    if (err < 0) {
    --
    1.6.6.rc0


    \
     
     \ /
      Last update: 2009-12-14 11:37    [W:0.020 / U:1.500 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site