lkml.org 
[lkml]   [2009]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [BUGFIX][PATCH] oom-kill: fix NUMA consraint check with nodemask v4.2
    On Mon, 14 Dec 2009 20:30:37 -0800 (PST)
    David Rientjes <rientjes@google.com> wrote:

    > On Tue, 15 Dec 2009, KAMEZAWA Hiroyuki wrote:
    >
    > > I'm now preparing more counters for mm's statistics. It's better to
    > > wait and to see what we can do more. And other patches for total
    > > oom-killer improvement is under development.
    > >
    > > And, there is a compatibility problem.
    > > As David says, this may break some crazy software which uses
    > > fake_numa+cpuset+oom_killer+oom_adj for resource controlling.
    > > (even if I recommend them to use memcg rather than crazy tricks...)
    > >
    >
    > That's not at all what I said. I said using total_vm as a baseline allows
    > users to define when a process is to be considered "rogue," that is, using
    > more memory than expected. Using rss would be inappropriate since it is
    > highly dynamic and depends on the state of the VM at the time of oom,
    > which userspace cannot possibly keep updated.
    >
    > You consistently ignore that point: the power of /proc/pid/oom_adj to
    > influence when a process, such as a memory leaker, is to be considered as
    > a high priority for an oom kill. It has absolutely nothing to do with
    > fake NUMA, cpusets, or memcg.
    >
    You also ignore that it's not sane to use oom kill for resource control ;)

    Anyway, rss patch was dropped as you want.
    I'll prepare other ones.

    Thanks,
    -Kame



    \
     
     \ /
      Last update: 2009-12-15 05:49    [W:0.040 / U:0.988 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site