Messages in this thread | | | Date | Mon, 14 Dec 2009 20:08:27 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH] laptop-mode: Make flushes per-device |
| |
On Mon, Dec 14 2009, Matthew Garrett wrote: > On Sat, Dec 12, 2009 at 01:24:43PM +0100, Jens Axboe wrote: > > > That's because it is messy, why are you passing the request in? It > > would be a lot more sane to pass in the queue, better still the backing > > device. > > It seemed conceptually cleaner for the completion to refer to the > request rather than anything else, but that's easily fixed.
It's rather a major layering violation, I would claim... Passing in the bdi is design wise the cleanest.
> > What guarentees that the timer isn't running when the bdi goes away? > > Good point. I'll fix these and resend.
Thanks! As you can tell, laptop mode was pretty much for a laptop with a single drive back when it was created. It definitely seems like a good idea to make it per-drive granular now.
-- Jens Axboe
| |