Messages in this thread Patch in this message | | | From | Jean Delvare <> | Subject | [PATCH] fb/intelfb: Do not depend on EMBEDDED | Date | Sat, 12 Dec 2009 14:19:18 +0100 |
| |
I am worried that the intelfb driver depends on EMBEDDED. I consider this an abuse of the EMBEDDED configuration option, which as I understand it was originally meant to expose fine-tuning options, rather than to arbitrarily disable drivers when not selected.
So I suggest that we drop this dependency now.
Signed-off-by: Jean Delvare <jdelvare@suse.de> Cc: Jesse Barnes <jbarnes@virtuousgeek.org> Cc: Dave Airlie <airlied@linux.ie> --- Jesse, in the original commit, you wrote that intelfb was "really a special purpose embedded driver". It looks like a perfectly standard framebuffer driver to me, which means that it may have users beyond embedded. For example I always prefer framebuffer over X for my servers. Or am I missing something and intelfb is really special?
drivers/video/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.32.orig/drivers/video/Kconfig 2009-12-03 08:48:34.000000000 +0100 +++ linux-2.6.32/drivers/video/Kconfig 2009-12-11 10:57:43.000000000 +0100 @@ -1121,7 +1121,7 @@ config FB_CARILLO_RANCH config FB_INTEL tristate "Intel 830M/845G/852GM/855GM/865G/915G/945G/945GM/965G/965GM support (EXPERIMENTAL)" - depends on EXPERIMENTAL && FB && PCI && X86 && AGP_INTEL && EMBEDDED + depends on EXPERIMENTAL && FB && PCI && X86 && AGP_INTEL select FB_MODE_HELPERS select FB_CFB_FILLRECT select FB_CFB_COPYAREA -- Jean Delvare Suse L3
| |