Messages in this thread | | | Date | Fri, 11 Dec 2009 08:35:18 +0200 | From | Pekka Enberg <> | Subject | Re: [PATCH 1/2] tracing: Define kmem_trace_alloc_notrace unconditionally |
| |
Li Zefan kirjoitti: > 于 2009年12月11日 14:01, Pekka Enberg 写道: >> Pekka Enberg wrote: >>> Li Zefan wrote: >>>> Always define kmem_trace_alloc_{,node}_notrace(), otherwise >>>> perf-kmem will show wrong stats ifndef CONFIG_KMEMTRACE, >>>> because a kmalloc() memory allocation may be traced by >>>> both trace_kmalloc() and trace_kmem_cache_alloc(). >>>> >>>> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> >>> Did you check how much this will make kernel text bigger because of >>> the inlining happening in kmem_cache_alloc_notrace()? >> Maybe use CONFIG_TRACING instead of CONFIG_KMEMTRACE here like in the >> other patch? >> > > Wouldn't removing CONFIG_KMEMTRACE make the code cleaner? > Anyway, if CONFIG_TRACING is not enabled, all the trace_xxx() > will be turned into no-op.
Again, I am talking about kernel text size increase in mm/slub.c. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |