lkml.org 
[lkml]   [2009]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] x86/pci: use u64 instead of size_t in amd_bus.c
H. Peter Anvin wrote:
> On 12/11/2009 03:35 PM, Yinghai Lu wrote:
>>
>> prepare to enable it for 32bit
>>
>> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>>
>> ---
>> arch/x86/pci/amd_bus.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Index: linux-2.6/arch/x86/pci/amd_bus.c
>> ===================================================================
>> --- linux-2.6.orig/arch/x86/pci/amd_bus.c
>> +++ linux-2.6/arch/x86/pci/amd_bus.c
>> @@ -82,8 +82,8 @@ static int __init early_fill_mp_bus_info
>> struct pci_root_info *info;
>> u32 reg;
>> struct resource *res;
>> - size_t start;
>> - size_t end;
>> + u64 start;
>> + u64 end;
>> struct range range[RANGE_NUM];
>> u64 val;
>> u32 address;
>>
>
> Shouldn't this be resource_size_t?

it seems we should use u64, and check the if the sizeof(resource_size_t) != sizeof(u64)
and cap some vale.

YH


\
 
 \ /
  Last update: 2009-12-12 01:47    [W:0.221 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site