lkml.org 
[lkml]   [2009]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 01/58] jsm: IRQ handlers doesn't need to have IRQ_DISABLED enabled
    Date
    From: Breno Leitão <leitao@linux.vnet.ibm.com>

    Currently jsm is showing the following message when loaded:

    IRQ 432/JSM: IRQF_DISABLED is not guaranteed on shared IRQs

    It's because the request_irq() is called using IRQF_DISABLED
    and IRQF_SHARED.
    Actually there is no need to use IRQF_DISABLED in this driver.

    Signed-off-by: Breno Leitão <leitao@linux.vnet.ibm.com>
    Cc: Scott Kilau <scottk@digi.com>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    drivers/serial/jsm/jsm_driver.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/serial/jsm/jsm_driver.c b/drivers/serial/jsm/jsm_driver.c
    index b3604aa..48326f7 100644
    --- a/drivers/serial/jsm/jsm_driver.c
    +++ b/drivers/serial/jsm/jsm_driver.c
    @@ -123,7 +123,7 @@ static int __devinit jsm_probe_one(struct pci_dev *pdev, const struct pci_device
    }

    rc = request_irq(brd->irq, brd->bd_ops->intr,
    - IRQF_DISABLED|IRQF_SHARED, "JSM", brd);
    + IRQF_SHARED, "JSM", brd);
    if (rc) {
    printk(KERN_WARNING "Failed to hook IRQ %d\n",brd->irq);
    goto out_iounmap;
    --
    1.6.5.5
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-12-12 00:31    [W:5.918 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site