Messages in this thread | | | Subject | Re: [PATCH 3/3] gpiolib: use chip->names for symlinks, always use gpioN for device names | From | Ben Nizette <> | Date | Fri, 11 Dec 2009 16:12:37 +1100 |
| |
On Thu, 2009-12-10 at 19:47 -0800, Greg KH wrote: > On Thu, Dec 10, 2009 at 07:39:30PM -0800, David Brownell wrote: > > On Wednesday 09 December 2009, Jani Nikula wrote: > > > While the device names are now unique again, collisions in chip->names > > > will still prevent duplicates from being exported to sysfs. > > > > That's why I was never a real fan of chip->names...
Yea, poor idea indeed.
> > > > IMO a "good" solution in this space needs to accept that > > those names are not going to be globally unique ... but > > that they'll be unique within some context, of necessity. > > > > If Greg doesn't want to see those names under classes, > > so be it ... but where should they then appear? > > As a sysfs file within the device directory called 'name'? Then just > grep through the tree to find the right device, that also handles > duplicates just fine, right?
Well it bunts the handling of duplicates to who ever is grepping but yea, sounds good. The user script can sanity-check it's results against the controlling gpio-chip if need be. In fact, maybe symlink from gpioN/chip back to gpio-chipY could be useful? A bit redundant though, as you can check using the number ranges..
In fact I thought I had a patch to create /sys/class/gpio/gpioN/name at some stage.. Can't find it though, oh well.
--Ben.
| |