lkml.org 
[lkml]   [2009]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/12] crypto: Correct size given to memset
On Wed, Dec 09, 2009 at 08:23:09PM +0100, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Memset should be given the size of the structure, not the size of the pointer.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> type T;
> T *x;
> expression E;
> @@
>
> memset(x, E, sizeof(
> + *
> x))
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>

Luckily these functions aren't used by anything. Perhaps we
should get rid of them altogether.

Anyway, I've applied your patch. Thanks!
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


\
 
 \ /
  Last update: 2009-12-11 16:11    [W:0.048 / U:2.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site