Messages in this thread | | | Date | Fri, 11 Dec 2009 07:07:12 -0500 | From | Larry Woodman <> | Subject | Re: [PATCH] vmscan: limit concurrent reclaimers in shrink_zone |
| |
Minchan Kim wrote: > > I like this. but why do you select default value as constant 8? > Do you have any reason? > > I think it would be better to select the number proportional to NR_CPU. > ex) NR_CPU * 2 or something. > > Otherwise looks good to me. > > Reviewed-by: Minchan Kim <minchan.kim@gmail.com> > > This is a per-zone count so perhaps a reasonable default is the number of CPUs on the NUMA node that the zone resides on ?
| |