lkml.org 
[lkml]   [2009]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] perf tools: allow building for ARM
From
From: Ingo Molnar <mingo@elte.hu>
Date: Fri, 11 Dec 2009 11:23:16 +0100

>
> * Jamie Iles <jamie.iles@picochip.com> wrote:
>
>> +#ifdef __arm__
>> +#include "../../arch/arm/include/asm/unistd.h"
>> +#define rmb() asm volatile("":::"memory")
>> +#define cpu_relax() asm volatile("":::"memory")
>> +#endif
>
> cpu_relax() looks fine, but rmb() seems not to match the one that can be
> found in arch/arm/:

I think he did it this way so it can compile in the meantime,
and that doing it right requires runtime cpu detection to
select which barrier instruction is even available on the
current ARM cpu.


\
 
 \ /
  Last update: 2009-12-11 11:41    [from the cache]
©2003-2011 Jasper Spaans