lkml.org 
[lkml]   [2009]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/41] VFS: Make lookup_hash() return a struct path
On Mon, Nov 30, 2009 at 01:04:13AM -0500, Erez Zadok wrote:
> In message <1256152779-10054-4-git-send-email-vaurora@redhat.com>, Valerie Aurora writes:
>
> > @@ -1937,7 +1942,8 @@ EXPORT_SYMBOL(filp_open);
> > */
> > struct dentry *lookup_create(struct nameidata *nd, int is_dir)
> > {
> > - struct dentry *dentry = ERR_PTR(-EEXIST);
> > + struct path path = { .dentry = ERR_PTR(-EEXIST) } ;
>
> I assume the compiler will initialize path.mnt to NULL. Is NULL what you
> want? Even if the compiler guarantees it, I think you should either
> explicitly init .mnt to NULL or leave a comment explaining what's going on
> -- so no future code reader will think that this was omitted; a comment can
> clarify your intentions more explicitly.

That is an unpleasant thing to look at. I rewrote the exit paths so
that this initialization was unnecessary.

Thanks,

-VAL


\
 
 \ /
  Last update: 2009-12-10 22:27    [from the cache]
©2003-2011 Jasper Spaans