Messages in this thread | | | Date | Thu, 10 Dec 2009 17:57:22 +0100 | From | Pavel Machek <> | Subject | Re: GPIO support for HTC Dream |
| |
Hi!
> This is still really screwy. Why are you creating your own version of > struct gpio_chip in addition to the one in include/asm-generic/gpio.h > (which you also appear to include in some places). It makes the code > extremely confusing. Other architectures use wrapper structures. Can you > have something like this instead: > > struct dream_gpio_chip { > struct gpio_chip chip; > > /* Dream specific bits */ > };
Well, unfortunately dream's gpio_chip definition is completely different to the one from include/asm-generic. I'll do the rename.
> The name of this function also needs to be changed to something less > generic since it is being exported globally.
Well, arm only ever supports one subarch, so...
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |