Messages in this thread | | | Date | Tue, 01 Dec 2009 19:29:33 -0500 | From | Masami Hiramatsu <> | Subject | Re: [PATCH v2] mm: Introduce coredump parameter structure |
| |
Andrew Morton wrote: > On Sat, 28 Nov 2009 23:41:19 -0500 > Masami Hiramatsu<mhiramat@redhat.com> wrote: > >> Introduce coredump parameter data structure (struct coredump_params) >> for simplifying binfmt->core_dump() arguments. >> >> Changes in v2: >> - Don't remove DUMP_WRITE() macro. > > What is the reason for this change? > > Please always include both the "what" and the "why" in changelog text.
I see.
> >> diff --git a/fs/binfmt_aout.c b/fs/binfmt_aout.c >> index b639dcf..346b694 100644 >> --- a/fs/binfmt_aout.c >> +++ b/fs/binfmt_aout.c >> @@ -32,7 +32,7 @@ >> >> static int load_aout_binary(struct linux_binprm *, struct pt_regs * regs); >> static int load_aout_library(struct file*); >> -static int aout_core_dump(long signr, struct pt_regs *regs, struct file *file, unsigned long limit); >> +static int aout_core_dump(struct coredump_params *cprm); >> >> static struct linux_binfmt aout_format = { >> .module = THIS_MODULE, >> @@ -89,8 +89,9 @@ if (file->f_op->llseek) { \ >> * dumping of the process results in another error.. >> */ >> >> -static int aout_core_dump(long signr, struct pt_regs *regs, struct file *file, unsigned long limit) >> +static int aout_core_dump(struct coredump_params *cprm) >> { > > Something horrid has mangled your patch.
Oops, sorry. maybe copy-and-paste buffer demon did it :-(
Thank you,
-- Masami Hiramatsu
Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division
e-mail: mhiramat@redhat.com
| |