Messages in this thread | | | Date | Tue, 1 Dec 2009 21:36:43 +0100 | From | Pavel Machek <> | Subject | Re: divide by zero in termios when setting bluetooth |
| |
On Tue 2009-12-01 19:00:10, Alan Cox wrote: > > > + /* Should never happen */ > > > + WARN_ON(1); > > > return 0; > > > > Does this mean WARN_ON() on user error? Maybe printk(KERN_ERR) with > > explanation would be better? > > It shouldn't be possible to cause that case user error or otherwise.
You are right, I did not notice for() loop above. I actually tested the change now, and it seems to fix the problem.
ACK.
Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |