Messages in this thread | | | Date | Tue, 1 Dec 2009 21:33:35 +1100 (EST) | From | James Morris <> | Subject | Re: [Patch] selinux: remove an unreachable line |
| |
On Tue, 1 Dec 2009, Cong Wang wrote:
> > > default: > > > return -EINVAL; > > > } > > > - return -EINVAL; > > > } > > > > I think it's better to remove the default case. > > > > This is totally a personal taste, I think. > Either is OK. James, any comments?
Leave the default: there but with a comment /* fall through */ instead of the return.
-- James Morris <jmorris@namei.org>
| |