lkml.org 
[lkml]   [2009]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: specjbb2005 and aim7 regression with 2.6.32-rc kernels
From
Date
On Mon, 2009-11-09 at 08:09 +0100, Mike Galbraith wrote:
> + smp_read_barrier_depends();
> cpumask_setall(cpus);
> + cpumask_and(cpus, cpus, cpu_online_mask);


how about: cpumask_copy(cpus, cpu_online_mask); ?

Also, iirc cpu_online_mask is guaranteed stable when preemption is
disabled, otherwise you need to use get/put_online_cpus(), an
rmb_depends() won't do.



\
 
 \ /
  Last update: 2009-11-09 10:17    [W:0.055 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site