lkml.org 
[lkml]   [2009]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm] char, moxa: Make isabrds variable global.
On 11/09/2009 03:06 AM, Rakib Mullick wrote:
> On 11/7/09, Jiri Slaby <jirislaby@gmail.com> wrote:
>>
>> Sorry I had no time to look into the first patch. And it makes no sense.
>> The driver is unusable on !MODULE && !PCI. So better fix is to disallow
>> whole build on such configurations. Care to fix that?
>>
> Hi Jiri, thanks for your care. Would you please checkout the
> patch below? Is it okay?

Actually I'm idiot. I forgot, that today people can just pass "module
parameters" on the kernel cmdline even on !MODULE in the
KBUILD_MODNAME.param manner. So no, a better fix is to remove !MODULE
ifdefs completely.

Sorry for the confusion.


\
 
 \ /
  Last update: 2009-11-09 09:23    [W:0.055 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site