[lkml]   [2009]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v7 17/17] tracing: make function graph tracer work with -mmcount-ra-address
Wu Zhangjin wrote:
> + cflags-y += $(call cc-option, -mmcount-ra-address)
> +#if (__GNUC__ <= 4 && __GNUC_MINOR__ < 5)

Sprinkling the code with these #if clauses is ugly and prone to breakage
I think.

The Makefile part is testing for the same feature.

We do a very similar thing with -msym32, and KBUILD_SYM32. Perhaps you
could rework this patch in a similar manner and test for
KBUILD_MCOUNT_RA_ADDRESS instead of the '(__GNUC__ <= 4 &&
__GNUC_MINOR__ < 5)'

David Daney

 \ /
  Last update: 2009-11-09 23:37    [W:0.164 / U:0.212 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site