Messages in this thread | | | Date | Sun, 8 Nov 2009 12:30:13 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH v2 3/7] Adding general performance benchmarking subcommand to perf. |
| |
* Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> wrote:
> From: Ingo Molnar <mingo@elte.hu> > Subject: Re: [PATCH v2 3/7] Adding general performance benchmarking subcommand to perf. > Date: Tue, 3 Nov 2009 18:29:26 +0100 > > > > > * Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp> wrote: > > > > > > > > Adding general performance benchmarking subcommand to perf. > > > This patch adds bench/sched-pipe.c. > > > > > > bench/sched-pipe.c is a benchmark program > > > to measure performance of pipe() system call. > > > This benchmark is based on pipe-test-1m.c by Ingo Molnar. > > > http://people.redhat.com/mingo/cfs-scheduler/tools/pipe-test-1m.c > > > > > > Example of use: > > > % perf bench sched pipe # Use default options > > > 4.575 # Result is time > > > % perf bench sched pipe -l 2000 # This option means "loop 2000 counts" > > > 0.024 > > > > ok, -l makes sense. > > > > Shouldnt we output the unit of measurement, i.e. '4.575 usecs'? Also, we > > should perhaps print something like: > > > > % perf bench sched pipe > > > > (executing 1000000 pipe operations between two tasks) > > > > 4.575 usecs per op > > 218579 ops/sec > > > > ? > > I have to admit that single float value output is too simple. > So I'll fix the default output. > > But, I believe that simple form makes sense for > processing by scripts or graph tools like gnuplot. > I'll add the option (may be --simple) to switch > friendliness of outputs.
Btw., could you make it Git-ish, i.e.:
--format=short
or:
--format=simple
Eventually more format options might be added.
Ingo
| |