lkml.org 
[lkml]   [2009]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: linux-next: tip tree build warning
    [Ingo Molnar - Wed, Oct 28, 2009 at 08:50:12AM +0100]
    |
    | * Stephen Rothwell <sfr@canb.auug.org.au> wrote:
    |
    | > Hi all,
    | >
    | > On Wed, 28 Oct 2009 18:41:26 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
    | > >
    | > > static inline physid_mask_t default_apicid_to_cpu_present(int phys_apicid)
    | > > {
    | > > return physid_mask_of_physid(phys_apicid);
    | > > }
    | >
    | > I just noticed that this function (default_apicid_to_cpu_present) is
    | > declared "static inline in a header" but looks like it is only used by
    | > assigning its address to a function pointer. Its only use for x86_64
    | > is in arch/x86/kernel/apic/apic_noop.c ...
    |
    | yes, that might be a real problem - returning the mask like that is
    | messy. Thanks, will check.
    |
    | Ingo
    |

    Darn, my fault sorry! Here is an update which fixes the issue.
    (Btw, Stephen could you CC me next time if you get commit id
    with me in authors, so I wouldn't miss problem).

    Please review, comments/complains are quite welcome!

    -- Cyrill
    ---
    x86,apic: Get rid of apicid_to_cpu_present assign on X86-64

    In fact it's never get used on x86-64 (for 64 bit platform
    we use differ technique to enumerate io-units).

    Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
    ---
    arch/x86/kernel/apic/apic_noop.c | 5 +++++
    1 file changed, 5 insertions(+)

    Index: linux-2.6.git/arch/x86/kernel/apic/apic_noop.c
    =====================================================================
    --- linux-2.6.git.orig/arch/x86/kernel/apic/apic_noop.c
    +++ linux-2.6.git/arch/x86/kernel/apic/apic_noop.c
    @@ -162,7 +162,12 @@ struct apic apic_noop = {

    .cpu_to_logical_apicid = noop_cpu_to_logical_apicid,
    .cpu_present_to_apicid = default_cpu_present_to_apicid,
    +
    +#ifdef CONFIG_X86_32
    .apicid_to_cpu_present = default_apicid_to_cpu_present,
    +#else
    + .apicid_to_cpu_present = NULL,
    +#endif

    .setup_portio_remap = NULL,
    .check_phys_apicid_present = default_check_phys_apicid_present,

    \
     
     \ /
      Last update: 2009-11-08 14:19    [W:0.022 / U:31.640 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site