lkml.org 
[lkml]   [2009]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] PM: Thaws refrigerated and to be exited kernel threads
    Hi!

    > Kicks out a frozen thread from the refrigerator when an active thread has
    > invoked kthread_stop on the frozen thread.
    >
    > Signed-off-by: Romit Dasgupta <romit@ti.com>
    > ---
    >
    > diff --git a/kernel/freezer.c b/kernel/freezer.c
    > index bd1d42b..c28dbe8 100644
    > --- a/kernel/freezer.c
    > +++ b/kernel/freezer.c
    > @@ -9,6 +9,7 @@
    > #include <linux/module.h>
    > #include <linux/syscalls.h>
    > #include <linux/freezer.h>
    > +#include <linux/kthread.h>
    >
    > /*
    > * freezing is complete, mark current process as frozen
    > @@ -49,7 +50,7 @@ void refrigerator(void)
    >
    > for (;;) {
    > set_current_state(TASK_UNINTERRUPTIBLE);
    > - if (!frozen(current))
    > + if (!frozen(current) || (!current->mm && kthread_should_stop()))
    > break;
    > schedule();

    Well, what if the thread does some processing before stopping? That
    would break refrigerator assumptions...
    Pavel

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2009-11-07 17:57    [W:0.023 / U:32.996 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site