lkml.org 
[lkml]   [2009]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: linux-next: sparc tree build failure
From
From: David Miller <davem@davemloft.net>
Date: Fri, 06 Nov 2009 00:19:30 -0800 (PST)

> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 6 Nov 2009 18:02:48 +1100
>
>> Caused by commit d4ac42a582e46d7f86f0acb4253a310423c72c4c ("sparc:
>> Support for GRLIB APBUART serial port") (yes again :-)). I have applied
>> my patch to make it only build on SPARC again ...
>>
>> (Including linux/of_platform.h - where struct of_platform_driver,
>> of_register_driver() and of_platform_bus_type are declared - would be a
>> good start ... and the code should probably be using
>> of_register_platform_driver() instead of of_register_driver() in any
>> case.)
>
> Sorry, sparc is getting those headers indirectly.
>
> I'll fix this up.

Stephen, can you let me know if this takes care of everything?

I also noticed that the of_driver was not being unregistered on
module unload.

apbuart: Fix build and missing driver unregister.

linux/of_platform.h needs to be included

OF driver needs to be unregistered

Signed-off-by: David S. Miller <davem@davemloft.net>


\
 
 \ /
  Last update: 2009-11-06 09:29    [from the cache]
©2003-2011 Jasper Spaans