lkml.org 
[lkml]   [2009]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[54/99] nilfs2: fix dirty page accounting leak causing hang at write
    2.6.31-stable review patch.  If anyone has any objections, please let us know.

    ------------------
    From: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>

    commit b1e19e5601277845b4f17ecd7c9ba04f73ee11aa upstream.

    Bruno Prémont and Dunphy, Bill noticed me that NILFS will certainly
    hang on ARM-based targets.

    I found this was caused by an underflow of dirty pages counter. A
    b-tree cache routine was marking page dirty without adjusting page
    account information.

    This fixes the dirty page accounting leak and resolves the hang on
    arm-based targets.

    Reported-by: Bruno Prémont <bonbons@linux-vserver.org>
    Reported-by: Dunphy, Bill <WDunphy@tandbergdata.com>
    Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
    Tested-by: Bruno Prémont <bonbons@linux-vserver.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/nilfs2/btnode.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/fs/nilfs2/btnode.c
    +++ b/fs/nilfs2/btnode.c
    @@ -276,8 +276,7 @@ void nilfs_btnode_commit_change_key(stru
    "invalid oldkey %lld (newkey=%lld)",
    (unsigned long long)oldkey,
    (unsigned long long)newkey);
    - if (!test_set_buffer_dirty(obh) && TestSetPageDirty(opage))
    - BUG();
    + nilfs_btnode_mark_dirty(obh);

    spin_lock_irq(&btnc->tree_lock);
    radix_tree_delete(&btnc->page_tree, oldkey);

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-11-06 23:37    [W:0.035 / U:185.432 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site