Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [PATCH] ptrace: copy_thread() should clear TIF_SINGLESTEP and X86_EFLAGS_TF | Date | Fri, 6 Nov 2009 14:10:02 -0800 (PST) |
| |
> I thought this flag has no effect without TIF_SINGLESTEP, and it is > always updated by enable_single_step().
Right, but to be anal about the semantics you shouldn't clear TF if it's not set, etc.
> user_disable_single_step() is very much arch-dependent, I am worried > if it is safe to call it from copy_process(), when the new task_struct, > thread_info, etc are not properly initialized yet...
Well, arch people can weigh in about if it is problematical. Skimming over the existing arch definitions, it looks OK to me.
Thanks, Roland
| |