Messages in this thread | | | Date | Thu, 5 Nov 2009 00:06:13 -0500 | Subject | Re: Possible suspend/resume regression in .32-rc? | From | Haojian Zhuang <> |
| |
On Tue, Nov 3, 2009 at 4:50 AM, Stanislav Brabec <utx@penguin.cz> wrote: > Haojian Zhuang wrote: >> On Mon, Nov 2, 2009 at 5:57 AM, Stanislav Brabec <utx@penguin.cz> wrote: >> > Haojian Zhuang wrote: >> > >> >> Commit b5b82df6, from May 2007, breaks no_console_suspend on the OLPC >> >> XO laptop. Basically what happens is that upon returning from resume, >> >> serial8250_resume_port() will reconfigure the port for high speed >> >> mode and all console output will be garbled, making debug of the >> >> resume path painful. This patch modifies uart_resume_port() to >> >> reset the port to the state it was in before we suspended. >> > >> > See my patch waiting for approval in LKML thread >> > "serial-core: resume serial hardware with no_console_suspend". >> > >> > It attempts to fix it, but I was not yet able to test it due to spitz >> > resume breakage. >> > >> >> Hi Stanislav, >> >> At first, your patch can't be applied into my latest codebase. I have >> to update the patch. But the console resume is still blocked after >> applied your patch. It works only after I merge some old code back. My >> modified patch is in below. > > Yes, code changed there a bit. I sent rebased patch later in the thread. > Did you try this one? (Well I did not test it yet - in time of sending > resume did not work at all on my Zaurus.) > > Your patch is a bit different. I'll test both as soon as possible. > >
Your latest patch works well in my platform. Thanks a lot.
| |