Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 05/10] kbuild: sort the list of symbols exported by the kernel (__ksymtab) | Date | Wed, 4 Nov 2009 18:49:42 +1030 |
| |
On Tue, 3 Nov 2009 08:36:17 pm Alan Jenkins wrote: > +/* > + * We use CPP macros since they are more familiar than assembly macros. > + * Note that CPP macros eat newlines, so each statement must be terminated > + * by a semicolon. > + */ > + > +#ifdef CONFIG_HAVE_SYMBOL_PREFIX > +#define __SYM(sym) _##sym > +#else > +#define __SYM(sym) sym > +#endif
Ideally, you would used MODULE_SYMBOL_PREFIX here, but of course it's a string. I don't think Kconfig can do arbitrary identifiers, so we can't make CONFIG_SYMBOL_PREFIX empty or _.
Perhaps clarify it to a bool CONFIG_HAVE_MODULE_UNDERSCORE_PREFIX then, since that's what you're assuming here?
Thanks, Rusty.
| |