lkml.org 
[lkml]   [2009]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRE: [PATCH -2nd repost 2/4] SCSI: remove unnecessary NULL test
    Date
    From
    Yes, the check is not necessary.

    Thanks,
    Karen

    -----Original Message-----
    From: linux-scsi-owner@vger.kernel.org
    [mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of Jiri Slaby
    Sent: Wednesday, November 04, 2009 8:15 AM
    To: James.Bottomley@suse.de
    Cc: aacraid@adaptec.com; james.smart@emulex.com;
    linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Jiri Slaby
    Subject: [PATCH -2nd repost 2/4] SCSI: remove unnecessary NULL test

    Stanse found that c3cn is poked many times around in
    cxgb3i_conn_pdu_ready, there is no need to check if it is NULL.

    Remove the test.

    Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
    Cc: James E.J. Bottomley <James.Bottomley@suse.de>
    ---
    drivers/scsi/cxgb3i/cxgb3i_pdu.c | 6 ++----
    1 files changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/scsi/cxgb3i/cxgb3i_pdu.c
    b/drivers/scsi/cxgb3i/cxgb3i_pdu.c
    index 7091050..64bbc28 100644
    --- a/drivers/scsi/cxgb3i/cxgb3i_pdu.c
    +++ b/drivers/scsi/cxgb3i/cxgb3i_pdu.c
    @@ -461,10 +461,8 @@ void cxgb3i_conn_pdu_ready(struct s3_conn *c3cn)
    skb = skb_peek(&c3cn->receive_queue);
    }
    read_unlock(&c3cn->callback_lock);
    - if (c3cn) {
    - c3cn->copied_seq += read;
    - cxgb3i_c3cn_rx_credits(c3cn, read);
    - }
    + c3cn->copied_seq += read;
    + cxgb3i_c3cn_rx_credits(c3cn, read);
    conn->rxdata_octets += read;

    if (err) {
    --
    1.6.4.2
    --
    To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html


    \
     
     \ /
      Last update: 2009-11-04 19:15    [W:0.021 / U:0.668 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site