| Subject | [PATCH 14/13] sysfs: sysfs_setattr remove unnecessary permission check. | From | (Eric W. Biederman) | Date | Wed, 04 Nov 2009 04:04:02 -0800 |
| |
inode_change_ok already clears the SGID bit when necessary so there is no reason for sysfs_setattr to carry code to do the same, and it is good to kill the extra copy because when I moved the code, I goofed and in certain corner cases the code will look at the wrong gid.
Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com> --- fs/sysfs/inode.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/fs/sysfs/inode.c b/fs/sysfs/inode.c index 72e2e99..e2595a7 100644 --- a/fs/sysfs/inode.c +++ b/fs/sysfs/inode.c @@ -120,10 +120,6 @@ int sysfs_setattr(struct dentry * dentry, struct iattr * iattr) return error; iattr->ia_valid &= ~ATTR_SIZE; /* ignore size changes */ - if (iattr->ia_valid & ATTR_MODE) { - if (!in_group_p(inode->i_gid) && !capable(CAP_FSETID)) - iattr->ia_mode &= ~S_ISGID; - } error = inode_setattr(inode, iattr); if (error) -- 1.6.5.2.143.g8cc62
|