Messages in this thread | | | Subject | Re: [PATCH 2/3] ftrace: Return EINVAL when writing invalid val to set_ftrace_filter | From | Steven Rostedt <> | Date | Tue, 03 Nov 2009 23:43:02 -0500 |
| |
On Wed, 2009-11-04 at 10:58 +0800, Li Zefan wrote: > Frederic Weisbecker wrote: > > On Tue, Nov 03, 2009 at 08:56:28AM +0800, Li Zefan wrote: > >> Currently it doesn't warn user on invald value: > >> > >> # echo nonexist_symbol > set_ftrace_filter > >> > >> Better make it return failure. > >> > >> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> > >> --- > > > > > > Acked-by: Frederic Weisbecker <fweisbec@gmail.com> > > > > But shouldn't we have the same kind of check from > > ftrace_match_module_records() if we haven't matched > > anything with the regex? > > > > Right, I overlooked it. >
Only the first patch is urgent. I'll get that out and wait for you to update these other two (or just this one).
Thanks,
-- Steve
| |