lkml.org 
[lkml]   [2009]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 07/13] sysfs: Update s_iattr on link and unlink.
    Quoting Eric W. Biederman (ebiederm@xmission.com):
    > From: Eric W. Biederman <ebiederm@xmission.com>
    >
    > Currently sysfs updates the timestamps on the vfs directory
    > inode when we create or remove a directory entry but doesn't
    > update the cached copy on the sysfs_dirent, fix that oversight.

    confused... why not do this in sysfs_addrm_finish()?

    I guess you'd have to do at it at top before dropping sysfs_mutex
    so it wouldn't be as pretty as I was thinking, but at least you
    could just do it once.

    >
    > Acked-by: Tejun Heo <tj@kernel.org>
    > Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
    > ---
    > fs/sysfs/dir.c | 18 ++++++++++++++++++
    > 1 files changed, 18 insertions(+), 0 deletions(-)
    >
    > diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
    > index b5e8499..fa37126 100644
    > --- a/fs/sysfs/dir.c
    > +++ b/fs/sysfs/dir.c
    > @@ -464,6 +464,8 @@ void sysfs_addrm_start(struct sysfs_addrm_cxt *acxt,
    > */
    > int __sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
    > {
    > + struct sysfs_inode_attrs *ps_iattr;
    > +
    > if (sysfs_find_dirent(acxt->parent_sd, sd->s_name))
    > return -EEXIST;
    >
    > @@ -476,6 +478,13 @@ int __sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
    >
    > sysfs_link_sibling(sd);
    >
    > + /* Update timestamps on the parent */
    > + ps_iattr = acxt->parent_sd->s_iattr;
    > + if (ps_iattr) {
    > + struct iattr *ps_iattrs = &ps_iattr->ia_iattr;
    > + ps_iattrs->ia_ctime = ps_iattrs->ia_mtime = CURRENT_TIME;
    > + }
    > +
    > return 0;
    > }
    >
    > @@ -554,10 +563,19 @@ int sysfs_add_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
    > */
    > void sysfs_remove_one(struct sysfs_addrm_cxt *acxt, struct sysfs_dirent *sd)
    > {
    > + struct sysfs_inode_attrs *ps_iattr;
    > +
    > BUG_ON(sd->s_flags & SYSFS_FLAG_REMOVED);
    >
    > sysfs_unlink_sibling(sd);
    >
    > + /* Update timestamps on the parent */
    > + ps_iattr = acxt->parent_sd->s_iattr;
    > + if (ps_iattr) {
    > + struct iattr *ps_iattrs = &ps_iattr->ia_iattr;
    > + ps_iattrs->ia_ctime = ps_iattrs->ia_mtime = CURRENT_TIME;
    > + }
    > +
    > sd->s_flags |= SYSFS_FLAG_REMOVED;
    > sd->s_sibling = acxt->removed;
    > acxt->removed = sd;
    > --
    > 1.6.5.2.143.g8cc62
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html


    \
     
     \ /
      Last update: 2009-11-04 04:57    [W:2.873 / U:0.560 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site