Messages in this thread | | | Date | Tue, 03 Nov 2009 16:19:06 -0800 (PST) | Subject | Re: [PATCH] qlogicpti: add missing parentheses | From | David Miller <> |
| |
From: James Bottomley <James.Bottomley@suse.de> Date: Tue, 03 Nov 2009 17:51:49 -0600
> On Wed, 2009-11-04 at 00:38 +0100, Roel Kluin wrote: >> `+' has a higher precedence than `?' so the condition always >> evaluates to true and this is preprocessed to `7*((ql) - 1)' >> >> Signed-off-by: Roel Kluin <roel.kluin@gmail.com> >> --- >> drivers/scsi/qlogicpti.h | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> This one must be right, I think. > > It looks plausible ... but it will increase the mailbox segment length > by 4 ... someone needs to verify that this increase will actually work > and won't run off the end of the mailbox table.
It should be fine, good find Roel.
Acked-by: David S. Miller <davem@davemloft.net>
| |