lkml.org 
[lkml]   [2009]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [patch 18/28] watchdog: Remove BKL from rio watchdog driver
From
From: Thomas Gleixner <tglx@linutronix.de>
Date: Sat, 10 Oct 2009 15:36:48 -0000

> cycle_kernel_lock() was added with the BKL pushdown. The rio driver
> indeed needs that because riowd_device is initialized after
> misc_register(). So an open(), write/ioctl() which happens to get
> between misc_register returning and riowd_device initialization would
> dereference a NULL pointer.
>
> Move riowd_device initialization before misc_register() and get rid of
> cycle_kernel_lock().
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

Also applied to sparc-next-2.6, thanks!


\
 
 \ /
  Last update: 2009-11-03 06:19    [W:0.366 / U:4.972 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site