lkml.org 
[lkml]   [2009]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 05/41] VFS: Make real_lookup() return a struct path
    In message <1256152779-10054-6-git-send-email-vaurora@redhat.com>, Valerie Aurora writes:
    > From: Jan Blunck <jblunck@suse.de>
    >
    > This patch changes real_lookup() into returning a struct path.
    >
    > Signed-off-by: Jan Blunck <jblunck@suse.de>
    > Signed-off-by: Valerie Aurora <vaurora@redhat.com>
    > ---
    > fs/namei.c | 82 +++++++++++++++++++++++++++++++++++++----------------------
    > 1 files changed, 51 insertions(+), 31 deletions(-)
    >
    > diff --git a/fs/namei.c b/fs/namei.c
    > index 9c9ecfa..a338496 100644
    > --- a/fs/namei.c
    > +++ b/fs/namei.c
    > @@ -462,10 +462,11 @@ ok:
    > * make sure that nobody added the entry to the dcache in the meantime..
    > * SMP-safe
    > */
    > -static struct dentry * real_lookup(struct dentry * parent, struct qstr * name, struct nameidata *nd)
    > +static int real_lookup(struct nameidata *nd, struct qstr *name,
    > + struct path *path)
    > {

    Same comments I had on patch 3:

    - document in comment and patch header the new @path parameter, who is
    responsible for it, new return err, etc.

    - consider adding BUG_ON(!path)

    - perhaps VFS this should also be pushed upstream before UM

    Erez.


    \
     
     \ /
      Last update: 2009-11-30 03:13    [W:3.866 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site