Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 2/2] virtio: Convert virtio-rng to the new API | Date | Sat, 28 Nov 2009 20:30:31 +1030 |
| |
On Thu, 26 Nov 2009 10:55:27 am Ian Molton wrote: > This patch converts virtio-rng to the new hw_rng API. > > In the process it fixes a previously untriggered buffering bug where the > buffer is not drained correctly if it has a non-multiple-of-4 length.
Hi Ian,
Looks good. Minor comments below:
> @@ -16,6 +16,7 @@ > * along with this program; if not, write to the Free Software > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA > */ > + > #include <linux/err.h> > #include <linux/hw_random.h> > #include <linux/scatterlist.h>
Gratuitous hunk?
> -static unsigned int data_left; > +static unsigned int data_avail; > static DECLARE_COMPLETION(have_data); > +static int busy;
I prefer bool and true/false for booleans these days.
> + > +/* The host will fill any buffer we give it with sweet, sweet randomness. */
This comment belongs above register_buffer() now I think.
(But I'm glad you kept it!)
Thanks, Rusty.
| |