lkml.org 
[lkml]   [2009]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] vmscan: make lru_index() helper function


On Fri, 27 Nov 2009, KOSAKI Motohiro wrote:

> > > @@ -1373,10 +1378,8 @@ static void shrink_active_list(unsigned long nr_pages, struct zone *zone,
> > > */
> > > reclaim_stat->recent_rotated[file] += nr_rotated;
> > >
> > > - move_active_pages_to_lru(zone, &l_active,
> > > - LRU_ACTIVE + file * LRU_FILE);
> > > - move_active_pages_to_lru(zone, &l_inactive,
> > > - LRU_BASE + file * LRU_FILE);
> > > + move_active_pages_to_lru(zone, &l_active, lru_index(1, file));
> > > + move_active_pages_to_lru(zone, &l_inactive, lru_index(0, file));
> >
> > How about:
> > move_active_pages_to_lru(zone, &l_active, lru_index(LRU_ACTIVE, file));
> > move_active_pages_to_lru(zone, &l_inactive, lru_index(LRU_BASE, file));
> > ?
>
> No. lru_index mean convert two boolean to one index. it shoudn't be passed
> lru index itself.

Yeah, you are right, I immediately realized I am wrong after replying,
sorry.

Vincent



\
 
 \ /
  Last update: 2009-11-27 06:57    [W:0.048 / U:34.180 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site